Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide #1588

Merged
merged 3 commits into from Jun 28, 2022

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Feb 23, 2022

There is no need to draft release anymore - the release-drafter does the job.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

There is no need to draft release anymore - the `release-drafter` does the job.
@atugushev atugushev added the skip-changelog Avoid listing in changelog label Feb 23, 2022
@duoi
Copy link
Member

duoi commented Jun 16, 2022

@atugushev would you have any idea why this PR wasn't approved? Or did it just fall through the cracks?

@atugushev
Copy link
Member Author

would you have any idea why this PR wasn't approved? Or did it just fall through the cracks?

Hey @duoi. The pull request is just patiently waiting for reviewers :)

@atugushev atugushev merged commit d9b9a6c into jazzband:master Jun 28, 2022
@atugushev atugushev deleted the update-contributing-guide branch June 28, 2022 11:26
@atugushev
Copy link
Member Author

Thanks @duoi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants