Fix --generate-hashes when hashes are computed from files
#1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazerM
force-pushed
the
fix-cached-candidates
branch
from
c9b1fc3
to
cbb86c7
Compare
RazerM
force-pushed
the
fix-cached-candidates
branch
from
cbb86c7
to
1f79354
Compare
RazerM
force-pushed
the
fix-cached-candidates
branch
from
1f79354
to
78d873d
Compare
atugushev
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Thanks for the fix! Getting hashes from API released on pip-tools v5.1.0 2020-04-27 and lru_cache() added to PackageFinder.find_all_candidates() on 2020-10-30. That's why the bug was hard to notice. Good catch!
Fixes jazzband#1532 This issue only shows up for PyPI servers where we can't get hashes from a JSON API. When pip-compile runs, `find_all_candidates` first gets called outside of an `allow_all_wheels()` context, and pip caches the list of candidates. Later, while pip-compile computes hashes from the files, the effects of `allow_all_wheels()` are not seen because the cached candidates are returned. In order for the test to pass I've added a blank sdist for small-fake-multi-arch so that there's always at least one candidate when pypi_repository.get_hashes is called outside of allow_all_wheels
RazerM
force-pushed
the
fix-cached-candidates
branch
from
78d873d
to
1ccdea5
Compare
|
@RazerM feel free to squash and merge this after ci is green. |
atugushev
changed the title
--generate-hashes when hashes are computed from files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1532
This issue only shows up for PyPI servers where we can't get hashes from
a JSON API. When pip-compile runs,
find_all_candidatesfirst getscalled outside of an
allow_all_wheels()context, and pip caches thelist of candidates. Later, while pip-compile computes hashes from the
files, the effects of
allow_all_wheels()are not seen because thecached candidates are returned.
In order for the test to pass I've added a blank sdist for
small-fake-multi-arch so that there's always at least one candidate
when pypi_repository.get_hashes is called outside of allow_all_wheels
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.