Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyPy jobs to PR CI runs #1379

Merged
merged 6 commits into from Jun 20, 2021
Merged

Add PyPy jobs to PR CI runs #1379

merged 6 commits into from Jun 20, 2021

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Apr 7, 2021

Ref #1375 (comment)

Changelog-friendly one-liner: Added PyPy jobs to PR builds

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@webknjaz webknjaz requested a review from atugushev April 7, 2021 23:24
@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited

Codecov Report

Merging #1379 (158d5b8) into master (0487eed) will not change coverage.
The diff coverage is n/a.

❗ Current head 158d5b8 differs from pull request most recent head 4372dd1. Consider uploading reports for the commit 4372dd1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          33       33           
  Lines        2940     2940           
  Branches      308      308           
=======================================
  Hits         2930     2930           
  Misses          5        5           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0487eed...4372dd1. Read the comment docs.

@ssbarnea ssbarnea added the ci Related to continuous integration tasks label Jun 5, 2021
@ssbarnea ssbarnea self-requested a review June 5, 2021 09:49
@ssbarnea
Copy link
Member

@webknjaz Can you fix the tests or at least make them as known failures?

@ssbarnea ssbarnea added the awaiting response Awaiting response from a contributor label Jun 11, 2021
@ssbarnea ssbarnea added maintenance Related to maintenance processes and removed awaiting response Awaiting response from a contributor labels Jun 19, 2021
atugushev
atugushev reviewed Jun 19, 2021
View reviewed changes
tests/test_cli_compile.py
@@ -11,6 +11,8 @@

from .constants import MINIMAL_WHEELS_PATH, PACKAGES_PATH

is_pypy = "__pypy__" in sys.builtin_module_names
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's the canonical way to detect python implementation, maybe platform.python_implementation() == "PyPy"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may work too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, feel free to ignore the suggestion 👍🏻

webknjaz
webknjaz commented Jun 19, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
atugushev
atugushev approved these changes Jun 19, 2021
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

webknjaz
webknjaz commented Jun 19, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ssbarnea ssbarnea merged commit d8ac360 into master Jun 20, 2021
@ssbarnea ssbarnea deleted the maintenance/gha-pypy branch June 20, 2021 09:38
@atugushev atugushev mentioned this pull request Aug 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
ci Related to continuous integration tasks maintenance Related to maintenance processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@webknjaz @ssbarnea @atugushev