Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where pip-compile setup.py would fail due to URL dependency #1347

Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Mar 10, 2021

Fixes #1346.

Changelog-friendly one-liner: Fix a bug where pip-compile setup.py would fail with URL deps.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added bug fix setuptools Related to compiling requirements form setup.py labels Mar 10, 2021
@atugushev atugushev added this to the 6.0.0 milestone Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1347 (d05be7a) into master (fe6dd97) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files          33       33              
  Lines        2883     2882       -1     
  Branches      309      309              
==========================================
- Hits         2873     2872       -1     
  Misses          5        5              
  Partials        5        5              
Impacted Files Coverage Δ
piptools/scripts/compile.py 100.00% <100.00%> (ø)
tests/test_cli_compile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6dd97...d05be7a. Read the comment docs.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nstall_req_from_line() seems good solution. approving from my side. others should check

@atugushev atugushev merged commit 20d873d into jazzband:master Mar 11, 2021
@atugushev atugushev deleted the fix-bug-with-setuptools-and-vcs-1346 branch March 11, 2021 14:06
@atugushev
Copy link
Member Author

Thanks @auvipy 🙏🏼

install_req_from_line,
install_req_from_req_string,
)
from pip._internal.req.constructors import install_req_from_line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember struggling for hours to understand the difference between these two functions, and it seems that I still didn't fully get them... thanks @atugushev 👍🏽

This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setuptools Related to compiling requirements form setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile raises an exception when setup.py has a URL in install_requires directive
3 participants