Skip to content

Added Dutch translations #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

roadbearstudios
Copy link
Contributor

Merged with master and recompiled translations.

roadbearstudios and others added 5 commits May 22, 2020 16:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@roadbearstudios roadbearstudios changed the title Roadbearstudios/master Added Dutch translations Jun 16, 2021
Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roadbearstudios thanks for this! Compiling the translation into a .mo would be great!

@roadbearstudios
Copy link
Contributor Author

@roadbearstudios thanks for this! Compiling the translation into a .mo would be great!

I did, or am I missing something?

See this commit:

b08eaa9

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Jun 17, 2021

@roadbearstudios From the UI, GitHub says that you deleted the mo file (on accident ofc). From your branch as well, the mo file is not in the dir

@roadbearstudios
Copy link
Contributor Author

@roadbearstudios From the UI, GitHub says that you deleted the mo file (on accident ofc). From your branch as well, the mo file is not in the dir

You're totally right, I misread the commit. I added the mo-file now, thx!

Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roadbearstudios for some reason it seems like your line numbers are incorrect compared to master (and your branch as well). Can you double check that the line numbers are actually matching? Thanks!

@roadbearstudios
Copy link
Contributor Author

@roadbearstudios for some reason it seems like your line numbers are incorrect compared to master (and your branch as well). Can you double check that the line numbers are actually matching? Thanks!

I ran makemessages before compiling now. Should be correct now.

@Andrew-Chen-Wang
Copy link
Member

@roadbearstudios does the po file need to be recompiled to mo?

@roadbearstudios
Copy link
Contributor Author

@roadbearstudios does the po file need to be recompiled to mo?

I did, but according to compilemessages the mo was not changed

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit cba4a96 into jazzband:master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants