Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make phonenumber plugin really a plugin #654

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

make phonenumber plugin really a plugin #654

wants to merge 1 commit into from

Conversation

jpaniagualaconich
Copy link
Contributor

@jpaniagualaconich jpaniagualaconich commented Sep 8, 2023 •
edited

Description

Motivation and Context

Fixes #469, fixes #581.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1928748) 97.84% compared to head (98ec23c) 95.52%.

❗ Current head 98ec23c differs from pull request most recent head b1a874c. Consider uploading reports for the commit b1a874c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   97.84%   95.52%   -2.32%     
==========================================
  Files          78       78              
  Lines        3384     3352      -32     
  Branches      384      377       -7     
==========================================
- Hits         3311     3202     -109     
- Misses         42      119      +77     
  Partials       31       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpaniagualaconich jpaniagualaconich force-pushed the better-phonenumber-plugin branch 4 times, most recently from 78c515d to a574d57 Compare September 8, 2023 20:38
@claudep
Copy link
Contributor

claudep commented Sep 10, 2023

I had a quick look, looks very good overall. Generally I prefer having smaller commits for various reasons, notably as it's easier to spot regressions when they happen. Do you think it would be possible to split your commit in smaller ones, targeted on more granular changes?

@jpaniagualaconich jpaniagualaconich force-pushed the better-phonenumber-plugin branch 3 times, most recently from 16ec9f5 to f12cc99 Compare September 10, 2023 12:28
@jpaniagualaconich jpaniagualaconich changed the title make phonenumber plugin really a plugin (#469) make phonenumber plugin really a plugin Sep 10, 2023
@jpaniagualaconich jpaniagualaconich force-pushed the better-phonenumber-plugin branch 7 times, most recently from 3ea487f to ebd1d78 Compare September 10, 2023 14:47
@jpaniagualaconich jpaniagualaconich marked this pull request as draft September 10, 2023 15:27
@jpaniagualaconich
Copy link
Contributor Author

@claudep then please check #656 #658 #660 #662 first.

Once they're merged we can continue with #666 and this one.

@jpaniagualaconich jpaniagualaconich force-pushed the better-phonenumber-plugin branch 2 times, most recently from a8d295d to 320e6d5 Compare September 10, 2023 16:26
@claudep
Copy link
Contributor

claudep commented Sep 10, 2023

That's great, thanks so much. I'll review the individual patches ASAP.

@jpaniagualaconich jpaniagualaconich force-pushed the better-phonenumber-plugin branch 2 times, most recently from 20107af to 98ec23c Compare September 11, 2023 08:47
@jpaniagualaconich jpaniagualaconich force-pushed the better-phonenumber-plugin branch 3 times, most recently from 23137db to 1068146 Compare February 4, 2024 18:20
@jpaniagualaconich
Copy link
Contributor Author

jpaniagualaconich commented Feb 4, 2024 •
edited

@claudep I think I'll do a PR adding some skips in tests that expect the phonenumber plugin to be present and perhaps refactor some of them before going on with this PR. What do you think?

@claudep
Copy link
Contributor

claudep commented Feb 4, 2024

Feel free to make some more incremental PRs, even if it is for small things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is phonenumbers a required dependency? Make phonenumber plugin really a plugin
2 participants
@jpaniagualaconich @claudep