Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing text for email #579

Open
pickfire opened this issue Jan 4, 2023 · 0 comments
Open

Missing text for email #579

pickfire opened this issue Jan 4, 2023 · 0 comments

Comments

@pickfire
Copy link
Contributor

pickfire commented Jan 4, 2023

Expected Behavior

There should be a text during email setup to say email has been sent.

We sent you an email, please enter the tokens we sent.

Same for the login text, I believe.

Current Behavior

No text mentioned.

Possible Solution

Show the text to say email has been sent.

Steps to Reproduce (for bugs)

  1. run setup with email

Context

image

Your Environment

  • Browser and version:
  • Python version:
  • Django version:
  • django-otp version: 1.1.4
  • django-two-factor-auth version: master d7abfd7
  • Link to your project: I tested with example/

I tried doing it with

  {% elif wizard.steps.current == 'validation' %}
    {% if challenge_succeeded %}
      {% if device.method == 'call' %}
        <p>{% blocktrans trimmed %}We are calling your phone right now, please enter the
          digits you hear.{% endblocktrans %}</p>
      {% elif device.method == 'sms' %}
        <p>{% blocktrans trimmed %}We sent you a text message, please enter the tokens we
          sent.{% endblocktrans %}</p>
      {% elif device.method == 'email' %}
        <p>{% blocktrans trimmed %}We sent you an email, please enter the tokens we sent.
          {% endblocktrans %}</p>
      {% endif %}
    {% else %}

{% elif wizard.steps.current == 'validation' %}
{% if challenge_succeeded %}
{% if device.method == 'call' %}
<p>{% blocktrans trimmed %}We are calling your phone right now, please enter the
digits you hear.{% endblocktrans %}</p>
{% elif device.method == 'sms' %}
<p>{% blocktrans trimmed %}We sent you a text message, please enter the tokens we
sent.{% endblocktrans %}</p>
{% endif %}
{% else %}

But looks like there is no method for EmailDevice which we took from django_otp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant