Remove unneeded content_type strip #642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comment #641 (review), there's not a good reason to have these lines that attempt to strip
content_type
.If
strip()
is a method on a string,strip()
will return a string making thestrip()
a few lines below superfluous (s.strip().strip() == s.strip()
). Ifstrip()
does trigger the try/catch, the try/catch will be ineffective anyways because the laterstrip()
will also trigger anAttributeError
. There is a possibility that a different type implementsstrip()
in a way that multiple strips have different behavior, but it doesn't seem possible given how the_parse_content_type
function is called.