Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded pytz package #603

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

albertyw
Copy link
Member

Following up on #581, remove the pytz package which was only being used in tests to load the UTC offset which by definition is always 0. django.utils.timezone.utc (as well as datetime.timezone.utc) both suffice and are already available to be imported in django-silk.

Fixes #581

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #603 (a0ad8cd) into master (c12ce22) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   84.60%   84.63%   +0.02%     
==========================================
  Files          52       52              
  Lines        2072     2076       +4     
==========================================
+ Hits         1753     1757       +4     
  Misses        319      319              
Impacted Files Coverage Δ
silk/middleware.py 89.32% <0.00%> (-0.11%) ⬇️
silk/collector.py 89.70% <0.00%> (-0.08%) ⬇️
silk/model_factory.py 83.40% <0.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@albertyw albertyw merged commit 7ba0a55 into jazzband:master Oct 13, 2022
@albertyw albertyw deleted the remove-pytz branch October 13, 2022 03:39
@albertyw albertyw mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Drop dependency on pytz in favor of zoneinfo
1 participant