Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jquery UI 1.13.1 images and fix collectstatic #576

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

drfb
Copy link
Contributor

@drfb drfb commented Jul 1, 2022

Django collectstatic fails for references inside css comments. Running collectstatic will produce an error:

The CSS file 'silk/lib/jquery-ui-1.13.1.min.css' references a file which could not be found:
  silk/lib/"images/ui-icons_555555_256x240.png"

Reference: https://code.djangoproject.com/ticket/21080

@joshuadavidthomas
Copy link
Member

Thanks @drfb!

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #576 (53b2600) into master (5afcdea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files          52       52           
  Lines        2072     2072           
=======================================
  Hits         1753     1753           
  Misses        319      319           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afcdea...53b2600. Read the comment docs.

@joshuadavidthomas joshuadavidthomas requested review from joshuadavidthomas and removed request for joshuadavidthomas July 1, 2022 15:13
@joshuadavidthomas
Copy link
Member

Fixes #574

@albertyw
Copy link
Member

albertyw commented Jul 1, 2022

Thanks for the fix. I'll merge and make a new release shortly.

@albertyw albertyw merged commit ab3d86e into jazzband:master Jul 3, 2022
albertyw pushed a commit to albertyw/django-silk that referenced this pull request Jul 3, 2022
* Add missing jquery-ui 1.13.1 images

* Remove css comment with url in jquery-ui
albertyw added a commit to albertyw/django-silk that referenced this pull request Jul 3, 2022
* v4:
  Release version v4.4.1 (jazzband#579)
  Add jquery UI 1.13.1 images and fix collectstatic (jazzband#576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants