traceback only when needed #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculate traceback only if we need to wrap sql
auvipy
suggested changes
Jan 4, 2020
|
looks like not updates to tests are needed for this |
|
can you check here https://github.com/jazzband/django-silk/blob/master/project/tests/test_view_sql_detail.py and related files? |
|
@ilndinesh Can you rebase this to the latest django-silk:master |
VisheshBansal
requested review from
VisheshBansal
and removed request for
VisheshBansal
|
This can be considered as code cleanup/performance optimization and could be merged as is (provided the tests pass) |
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 52 52
Lines 2093 2093
=======================================
Hits 1807 1807
Misses 286 286
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Archmonger
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculate traceback only if we need to wrap sql