Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over from GCM to FCM #618

Open
ayushin opened this issue Jul 25, 2021 · 0 comments · May be fixed by #615
Open

Switch over from GCM to FCM #618

ayushin opened this issue Jul 25, 2021 · 0 comments · May be fixed by #615
Labels

Comments

@ayushin
Copy link

ayushin commented Jul 25, 2021

My understanding that nobody uses GCM anymore, so perhaps it is time for the upgrade?

My suggestion would be to rename GCM model to FCM model (breaking change) and add platform choices/enum to it, like I've done in the #615

I agree perhaps there is no reason to keep the GCM model anymore and message_type but it will be a (small) breaking change.

What are your thoughts?

  1. Rename GCM to FCM?

  2. Keep GCM as a proxy model for backward compatibility? (seems like unnecessary work)

  3. platform choices:

a) android, ios, web - full text in the database consistent with the rest of the library
b) a, i, w - save space
c) 0, 1, 2 - save space, easy indexing, sorting
d) new django enums

@Andrew-Chen-Wang Andrew-Chen-Wang linked a pull request Jul 31, 2021 that will close this issue
@azmeuk azmeuk added the gcm/fcm label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants