Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for 1.4.0 release #921

Merged
merged 1 commit into from
Feb 8, 2021
Merged

prepare for 1.4.0 release #921

merged 1 commit into from
Feb 8, 2021

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented Feb 7, 2021

Description of the Change

1.4.0 Release

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk marked this pull request as draft February 7, 2021 19:46
@n2ygk n2ygk added this to the 1.4.0 milestone Feb 7, 2021
@n2ygk
Copy link
Member Author

n2ygk commented Feb 7, 2021

@MattBlack85 Just need your merge of #920 and then final review here.

@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #921 (f38a584) into master (e1760df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          25       25           
  Lines        1070     1070           
=======================================
  Hits         1017     1017           
  Misses         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1760df...40c641d. Read the comment docs.

@MattBlack85
Copy link
Contributor

@n2ygk push the date to the changelog and we are g2g 🚀

@n2ygk n2ygk marked this pull request as ready for review February 8, 2021 14:19
@n2ygk
Copy link
Member Author

n2ygk commented Feb 8, 2021

@n2ygk push the date to the changelog and we are g2g 🚀

@MattBlack85 ready for your review.

@n2ygk
Copy link
Member Author

n2ygk commented Feb 8, 2021

FYI I just noticed a bunch of merged PRs that were labeled for 1.5.0 milestone. I changed them to 1.4.0.

Copy link
Contributor

@MattBlack85 MattBlack85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MattBlack85 MattBlack85 merged commit 37640ee into jazzband:master Feb 8, 2021
@n2ygk n2ygk deleted the release140 branch February 8, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants