Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd try at getting pt-PT PR #690 to merge #920

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented Feb 7, 2021

Fixes #690, #919

Description of the Change

Due to some confusion around ability to merge #690 this PR is my 2nd attempt. I've taken #690 and made some changes:

  • Added @srtab's name to AUTHORS
  • Updated the CHANGELOG
  • Removed unnecessary header comments from LC_MESSAGES/django.po
  • Updated docs/contributing.rst to describe how to add additional translations.

I don't know if there's a need for unit tests to confirm the translations are working as expected.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk marked this pull request as draft February 7, 2021 18:40
@n2ygk n2ygk added this to the 1.3.4 milestone Feb 7, 2021
@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #920 (f21c0f4) into master (b9083eb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          25       25           
  Lines        1070     1070           
=======================================
  Hits         1017     1017           
  Misses         53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9083eb...4cdb061. Read the comment docs.

@n2ygk n2ygk marked this pull request as ready for review February 7, 2021 19:22
@n2ygk n2ygk mentioned this pull request Feb 7, 2021
5 tasks
@MattBlack85 MattBlack85 merged commit e1760df into jazzband:master Feb 8, 2021
@n2ygk n2ygk deleted the pt-PT branch February 8, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants