#898 Added the ability to customize classes for django admin #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1518
💛 - Coveralls |
|
@folt the PR looks good to me but I can't see any test for a custom admin class, could you add one for that case also? |
MattBlack85
reviewed
Dec 14, 2020
| @@ -128,13 +134,13 @@ class OAuth2ProviderSettings: | |||
|
|
|||
| def __init__(self, user_settings=None, defaults=None, import_strings=None, mandatory=None): | |||
| self.user_settings = user_settings or {} | |||
| self.defaults = defaults or {} | |||
| self.import_strings = import_strings or () | |||
| self.defaults = defaults or DEFAULTS | |||
There was a problem hiding this comment.
why you decided to pass DEFAULTS if we're not passing anything? This looks legit to me, tho I am wondering why it was {} and not DEFAULTS before
A good idea. I will add PR for this case |
MattBlack85
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description of the Change
#898 Added the ability to customize classes for django admin
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS