-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A limit on redirect_uri only up to 255 chars #902
Comments
@shaddeus thanks for raising this issue, can you provide a failing test case? |
@MattBlack85 Thanks for super fast response. Yes, I can provide failing test case (unit test, yes?). I will try to send a merge request with fix. |
@shaddeus sounds like a plan! |
Unfortunatelly I have a problem to write a corrent unit test for this. The problem depends on DB representation So the unit test passes always. The test must be run on another DB engine to fail. Should I append this "useless" test or not? |
@shaddeus I'd say let's add it, we may want to discuss then if we should test against another DB or that would be enough |
RFC 7230 recommends to design system to be capable to work with URI at least to 8000 chars long. This commit allows handle redirect_uri that is over 255 chars. Fixes issue jazzband#902.
RFC 7230 recommends to design system to be capable to work with URI at least to 8000 chars long. This commit allows handle redirect_uri that is over 255 chars. Fixes issue jazzband#902.
Why not select the |
@folt Hi. |
The requirement of 8000 characters for a link makes it impossible to use |
Why? In Django doc is written that
But we don't use For example MySQL and PostgreSQL have a limit 65535 chars for VARCHAR. But Yes, I'm not sure for other DB. |
I have a similar issue with the settings.py
myapp.auth.tokens.generate_jwt_access_token
|
Describe the bug
Cannot handle
redirect_uri
longer then 255 chars. RFC 7230 recommends to design system to be capable to work with URI at least to 8000 chars long.To Reproduce
Send a request to
AuthorizationView
withredirect_uri
longer than 255 chars.Expected behavior
To save
redirect_uri
intoGrant
model.Version
1.3.3
The text was updated successfully, but these errors were encountered: