Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python 3.9 to test matrix for djangomaster #884

Merged
merged 4 commits into from
Nov 14, 2020

Conversation

smithdc1
Copy link
Contributor

Description of the Change

Adds Python 3.9 to test matrix. Currently, released versions of Django don't officially support Python 3.9 but let's test against the 'master' branch for now.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@coveralls
Copy link

coveralls commented Oct 10, 2020

Pull Request Test Coverage Report for Build 1499

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.821%

Totals Coverage Status
Change from base Build 1498: 0.0%
Covered Lines: 1300
Relevant Lines: 1371

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1454

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 94.855%

Totals Coverage Status
Change from base Build 1448: 0.05%
Covered Lines: 1309
Relevant Lines: 1380

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 10, 2020

Pull Request Test Coverage Report for Build 1454

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 94.855%

Totals Coverage Status
Change from base Build 1448: 0.05%
Covered Lines: 1309
Relevant Lines: 1380

💛 - Coveralls

@MattBlack85
Copy link
Contributor

@smithdc1 as stated here https://docs.djangoproject.com/en/3.1/faq/install/ it seems that also django 3.0 and django 3.1 support officially python 3.9, can you please update the travis config accordingly?

@smithdc1
Copy link
Contributor Author

smithdc1 commented Oct 23, 2020 via email

@MattBlack85
Copy link
Contributor

@smithdc1 right, overlooked that one, yes, add it as well please!

@smithdc1
Copy link
Contributor Author

@MattBlack85 I've updated this. I've not added 3.1 yet as that is in #882 (will need to be updated, once this one is in).

@smithdc1
Copy link
Contributor Author

🥱 Travis...

@smithdc1
Copy link
Contributor Author

Sorry, should have spotted that this was failing before.

Looks to me like Travis doesn't support python 3.9 as yet.

How's your proposal of moving to another CI provider going. :-)

https://travis-ci.community/t/python-3-9-0-build/10091/10

@MattBlack85
Copy link
Contributor

MattBlack85 commented Oct 24, 2020 via email

@n2ygk
Copy link
Member

n2ygk commented Oct 24, 2020

Sorry, should have spotted that this was failing before.

Looks to me like Travis doesn't support python 3.9 as yet.

How's your proposal of moving to another CI provider going. :-)

https://travis-ci.community/t/python-3-9-0-build/10091/10

For now, just change .travis.yml to have:
python: 3.9-dev

That will get you 3.9.0+ (whatever that means).

@MattBlack85
Copy link
Contributor

@smithdc1 it looks like travis now support 3.9

@smithdc1
Copy link
Contributor Author

@MattBlack85 -- all updated 👍

@MattBlack85 MattBlack85 merged commit 29bed25 into jazzband:master Nov 14, 2020
@smithdc1 smithdc1 deleted the py39 branch November 14, 2020 19:16
@n2ygk n2ygk modified the milestones: 1.5.0, 1.4.0 Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants