Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pt-PT translations #690

Closed
wants to merge 4 commits into from
Closed

Added pt-PT translations #690

wants to merge 4 commits into from

Conversation

srtab
Copy link

@srtab srtab commented Jan 27, 2019

Added locale folder to project and pt-PT translations in it.
Made some missing strings available for translations too.

@coveralls
Copy link

coveralls commented Jan 27, 2019

Pull Request Test Coverage Report for Build 1155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.697%

Totals Coverage Status
Change from base Build 1153: 0.0%
Covered Lines: 1250
Relevant Lines: 1320

💛 - Coveralls

Copy link
Member

@IvanAnishchuk IvanAnishchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor fixes and should be good to go.

@MattBlack85 MattBlack85 modified the milestones: 1.3.3, 1.4.0 Oct 7, 2020
@MattBlack85 MattBlack85 modified the milestones: 1.3.4, 1.4.0 Oct 16, 2020
@MattBlack85
Copy link
Contributor

@n2ygk not sure how to proceed with this, this would be the first entry for translations

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n2ygk not sure how to proceed with this, this would be the first entry for translations

I'm OK with translations but we need some ground rules to make sure they are good translations and not just something pasted into Google Translate. How do other projects do this? Have a second native-language speaker review the PR?

CHANGELOG.md Show resolved Hide resolved
@Rainshaw
Copy link

@n2ygk hello, when will this pr be merged? I am looking forward to this feature.

@n2ygk n2ygk modified the milestones: 1.4.0, 1.3.4 Feb 7, 2021
@n2ygk n2ygk mentioned this pull request Feb 7, 2021
5 tasks
@n2ygk
Copy link
Member

n2ygk commented Feb 7, 2021

Ugh, I screwed up trying to merge this from command line. See #919

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with my changes...

@n2ygk
Copy link
Member

n2ygk commented Feb 7, 2021

I guess @srtab didn't allow pushes so I had to make a new PR #919 for this. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants