Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add divide by zero protection in timer.js #1687

Merged
merged 3 commits into from Oct 28, 2022
Merged

Add divide by zero protection in timer.js #1687

merged 3 commits into from Oct 28, 2022

Conversation

SmailBestybay
Copy link
Contributor

Fixes #1416

@tim-schilling
Copy link
Contributor

@matthiask I'm leaving this review to you. We created it during the sprints.

@matthiask
Copy link
Member

The fallback values are a bit confusing to me (zero in getLeft, 100 - getLeft() for the denominator, and then zero again)

The code still does the same thing in the happy path and divisions by zero shouldn't happen anymore so let's merge this.

Thanks!

@matthiask matthiask merged commit a859b7c into jazzband:main Oct 28, 2022
@SmailBestybay SmailBestybay deleted the 1416 branch October 28, 2022 07:13
@SmailBestybay SmailBestybay restored the 1416 branch October 28, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthiask matthiask

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: <rect> attribute width: Expected length, "NaN%".
3 participants
@SmailBestybay @tim-schilling @matthiask