Fix JS linting error from pre-commit. #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prettier v3 changed the default of trailing comma to all which seems to be problematic for ESLint.
|
I did a little digging for eslint configurations, but couldn't find an easy answer. |
|
https://www.npmjs.com/package/eslint-config-prettier would deactivate conflicting ESLint rules, but I think this fix is fine. |
|
Yeah, that's better. |
|
Hmm, I take that back. I think I like the change from this PR a bit more since it doesn't require use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier v3 changed the default of trailing comma to all which seems to be problematic for ESLint.