Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU Time includes DJDT's own time #1903

Open
vanschelven opened this issue Apr 10, 2024 · 4 comments
Open

CPU Time includes DJDT's own time #1903

vanschelven opened this issue Apr 10, 2024 · 4 comments

Comments

@vanschelven
Copy link

The CPU Time displayed in the DJDT shows the total time taken to render the request, including the time to render the DJDT itself. This is not what I care about, because the DJDT will not be there when running in production.

Is it possible to get the time elapsed of the actual rendered view on-screen somewhere?

@tim-schilling
Copy link
Contributor

If you're looking for metrics on the app running in production, I'd suggest looking into an APM product or an observability product.

@vanschelven
Copy link
Author

I don't think I said that although I see how what I said could be interpreted in that way. Let me clarify: in my case, the number as-shown was for c. 90% caused by the DJDT itself. Because I was in the assumption that the DJDT was saying something (mostly) about my code, rather than about itself, this led me on a wild goose chase, searching for the slowness in my application. This could have been prevented if the DJDT time/cpu panel had one or 2 lines about the "thing under measurement" explicitly

@tim-schilling
Copy link
Contributor

I appreciate the clarification.

I can see how that is a problem. I suspect it's possible for the tollbar middleware to track how long it's been running, then present that in the response along side the overall time.

I'm not sure we'd want to do the subtraction automatically because the total time is the total time. The toolbar is a part of the application.

Is that something you're interested in creating a PR for?

@vanschelven
Copy link
Author

Is that something you're interested in creating a PR for?

"maybe"... I'll let you know 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants