Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove OBSERVE_REQUEST_CALLBACK #1886

Open
tim-schilling opened this issue Feb 13, 2024 · 0 comments
Open

Deprecate and remove OBSERVE_REQUEST_CALLBACK #1886

tim-schilling opened this issue Feb 13, 2024 · 0 comments

Comments

@tim-schilling
Copy link
Contributor

With the addition of UPDATE_ON_FETCH from #1843, we no longer need to keep OBSERVE_REQUEST_CALLBACK around. The functionality that can be implemented with that can be redone in SHOW_TOOLBAR_CALLBACK as indicated by @living180 here

living180 added a commit to living180/django-debug-toolbar that referenced this issue Mar 11, 2024
With the addition of the UPDATE_ON_FETCH setting, the
OBSERVE_REQUEST_CALLBACK setting is redundant.  Thus add a check
debug_toolbar.W008 to warn if it is present in DEBUG_TOOLBAR_CONFIG,
but do not remove it yet.

See jazzband#1886
living180 added a commit to living180/django-debug-toolbar that referenced this issue Mar 11, 2024
With the addition of the UPDATE_ON_FETCH setting, the
OBSERVE_REQUEST_CALLBACK setting is redundant.  Thus add a check
debug_toolbar.W008 to warn if it is present in DEBUG_TOOLBAR_CONFIG,
but do not remove it yet.

See jazzband#1886
living180 added a commit to living180/django-debug-toolbar that referenced this issue Mar 11, 2024
With the addition of the UPDATE_ON_FETCH setting, the
OBSERVE_REQUEST_CALLBACK setting is redundant.  Thus add a check
debug_toolbar.W008 to warn if it is present in DEBUG_TOOLBAR_CONFIG,
but do not remove it yet.

See jazzband#1886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant