Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking STATICFILES_DIRS with Django 4 or better #1455

Merged
merged 1 commit into from Mar 6, 2021

Conversation

matthiask
Copy link
Member

Django 4.0 added its own check for this (staticfiles.W004).

Django 4.0 added its own check for this (staticfiles.W004).
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #1455 (644f8f5) into main (3dc5437) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
- Coverage   86.80%   86.44%   -0.36%     
==========================================
  Files          29       34       +5     
  Lines        1591     1844     +253     
  Branches      224      260      +36     
==========================================
+ Hits         1381     1594     +213     
- Misses        153      178      +25     
- Partials       57       72      +15     
Impacted Files Coverage Δ
debug_toolbar/views.py 75.00% <0.00%> (ø)
debug_toolbar/settings.py 100.00% <0.00%> (ø)
debug_toolbar/__init__.py 100.00% <0.00%> (ø)
debug_toolbar/panels/__init__.py 95.38% <0.00%> (ø)
debug_toolbar/utils.py 76.15% <0.00%> (ø)
debug_toolbar/panels/profiling.py 89.28% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc5437...1e36c05. Read the comment docs.

Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I was in the process of opening my PR to fix this and saw yours. Thank you.

@matthiask matthiask merged commit 06bf4ba into jazzband:main Mar 6, 2021
@matthiask matthiask deleted the dj40-staticfiles-dirs branch March 6, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants