Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with MariaDB #1121

Merged
merged 5 commits into from Dec 3, 2018
Merged

Run tests with MariaDB #1121

merged 5 commits into from Dec 3, 2018

Conversation

matthiask
Copy link
Member

No description provided.

@matthiask matthiask mentioned this pull request Nov 28, 2018
Merged
@matthiask
Copy link
Member Author

@dbowd I added a "true" BinaryField in this pull request because I couldn't get the test to work otherwise (I always got collation-related errors). While doing this I noticed that it was relatively straightforward to make the test pass in PostgreSQL and sqlite3 too. The formatting of the parameter is a bit different so I left it out though.

I'm a bit surprised though that the test also seems to pass without the DjangoUnicodeDecodeError thingy you added, so maybe the test tests something which it shouldn't now.

@matthiask matthiask merged commit a4a5393 into jazzband:master Dec 3, 2018
@matthiask matthiask deleted the mariadb branch December 3, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matthiask