serialized_data not included when m2m field changes

[alejandro-perez]

I have the following setting:

{"model": "opportunities.meeting", "serialize_data": True, "m2m_fields": ["consultants", "contacts"]},

When a field changes for a Meeting, "serialized_data" is provided. however, when one of t he M2M fields changes, the "serialized_data" field is left empty. I need serialized_data as a means to track changes to related objects. E.g the history of an opportunity includes the history of changes to all its meetings, and I find that by inspecting serialized_data and getting the value of the foreign key.

[alejandro-perez]

It seems that all is needed is to add

            kwargs.setdefault(
                "serialized_data", self._get_serialized_data_or_none(instance)
            )

to LogEntry.log_m2m_changes()

[alejandro-perez]

``` I confirm. Did you also check for the additional_data field? Although I define the get_additional_data method of the respective class, the additional_data field is not set. The method get_additional_data is called though. ``` No, I haven't checked that.

[alejandro-perez]

Which branch should I look at to see this fix? I cannot find it on master

[hramezani]

Sorry. I thought it got fixed.

Could you provide a patch with the fix?

[alejandro-perez]

It's just the line in #518 (comment). I can create a PR if that's preferrable

[hramezani]

It would be great if this change will fix the problem.

please remember you need to provide:

• a test to prove the fix
• a changelog entry in https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md

[alejandro-perez]

Ahh, that's why I didn't bother for just a one line change :)
I'll do it :)