{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":597689476,"defaultBranch":"V3.0","name":"Adv360-Pro-ZMK","ownerLogin":"jay-dee7","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-02-05T10:40:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/10788442?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1709798226.0","currentOid":""},"activityList":{"items":[{"before":"742d19ef634c84531b98a8d13c081610c38754ba","after":"b9b694c9dd6359bcef5f922ffb84e2071e90007b","ref":"refs/heads/V3.0","pushedAt":"2024-04-15T12:51:26.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Minor docs update (#445)","shortMessageHtmlLink":"Minor docs update (KinesisCorporation#445)"}},{"before":"1170346274a54d03261b973a65fd12b0915605b2","after":"aab3feb21155b5da501ede1331e6d1ea0ac10948","ref":"refs/heads/jay-dee7/V3.0","pushedAt":"2024-04-04T05:19:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"fix: Keyboard layout\n\nSigned-off-by: jay-dee7 ","shortMessageHtmlLink":"fix: Keyboard layout"}},{"before":"8cd5c47783632415b002974881a60a8aaec21229","after":"742d19ef634c84531b98a8d13c081610c38754ba","ref":"refs/heads/V3.0","pushedAt":"2024-04-04T05:17:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Fix Makefile errors that prevent builds on macOS (#409)","shortMessageHtmlLink":"Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409"}},{"before":"308a8d7dd01f4be66c5195ff8ba98ce5e87fe8dd","after":"1170346274a54d03261b973a65fd12b0915605b2","ref":"refs/heads/jay-dee7/V3.0","pushedAt":"2024-04-02T06:40:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"fix: Keyboard layout\n\nSigned-off-by: jay-dee7 ","shortMessageHtmlLink":"fix: Keyboard layout"}},{"before":"8f4af89f94fce3f4917c059b7b9ead959444ed11","after":"308a8d7dd01f4be66c5195ff8ba98ce5e87fe8dd","ref":"refs/heads/jay-dee7/V3.0","pushedAt":"2024-04-02T06:35:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"fix: Keyboard layout\n\nSigned-off-by: jay-dee7 ","shortMessageHtmlLink":"fix: Keyboard layout"}},{"before":"4a07f639e104686c06ccde4319e0e32d5226f8d1","after":"8f4af89f94fce3f4917c059b7b9ead959444ed11","ref":"refs/heads/jay-dee7/V3.0","pushedAt":"2024-04-02T06:31:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"fix: Keyboard layout\n\nSigned-off-by: jay-dee7 ","shortMessageHtmlLink":"fix: Keyboard layout"}},{"before":"dd3da03b9d8de287570d23245ff3a0c321bb0e31","after":"8cd5c47783632415b002974881a60a8aaec21229","ref":"refs/heads/V3.0","pushedAt":"2024-04-02T06:22:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"keymap-editor[bot]","name":null,"path":"/apps/keymap-editor","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/142212?s=80&v=4"},"commit":{"message":"Rework some layout stuff","shortMessageHtmlLink":"Rework some layout stuff"}},{"before":"7b81dc655be1eb1b683826f7ebc9fd819f7f59a5","after":"4a07f639e104686c06ccde4319e0e32d5226f8d1","ref":"refs/heads/jay-dee7/V3.0","pushedAt":"2024-03-07T08:03:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"fix: Layout formatting\n\nSigned-off-by: jay-dee7 ","shortMessageHtmlLink":"fix: Layout formatting"}},{"before":"dd3da03b9d8de287570d23245ff3a0c321bb0e31","after":null,"ref":"refs/heads/V2.0","pushedAt":"2024-03-07T07:57:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"}},{"before":null,"after":"dd3da03b9d8de287570d23245ff3a0c321bb0e31","ref":"refs/heads/V3.0","pushedAt":"2024-03-07T07:57:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Fix version.dtsi is reset after local firmware build (#385)\n\nIn #376 a new step was introduced for local builds to undo changes\r\nto the version.dtsi file after a build in order to reduce noise to the repo.\r\n\r\nUnfortunately the way used to execute the step causes the version.dtsi\r\nfile to be reset too early and therefore causes an incorrect version\r\nnumber to be used for the version macro when run locally. This went\r\nunfortunately undiscovered as the checked in version.dtsi was the same\r\non the day the change in #376 was tested and was not noticed until\r\nI build a new change to my keymap locally a few days ago.\r\n\r\nThe git command introduced in #376 is wrapped into a shell function.\r\n\r\nHowever what was missed is that commands run by the shell function are run when\r\nthe function calls are expanded by make. This causes the version.dtsi file to be reset\r\nbefore the firmware build process is even started which resultes in the version.dtsi\r\ncurrently checked in to the repo to be used for local builds instead of the\r\nnewly generated file when make starts.\r\n\r\nThis change updates how the git command to reset the version.dtsi\r\nis being called. It is no longer called within a shell function to ensure it\r\ndoes run in the order it is defined after the firmware build is complete.\r\n\r\nBuilds run through GitHub actions are not impacted and always used the correct version.dtsi\r\n\r\nFor more information and context see:\r\n - https://www.gnu.org/software/make/manual/html_node/Shell-Function.html\r\n - https://www.gnu.org/software/make/manual/html_node/Reading-Makefiles.html","shortMessageHtmlLink":"Fix version.dtsi is reset after local firmware build (KinesisCorporat…"}},{"before":"42a3ef791df86ea8a8bdc530a97a34c253efd188","after":null,"ref":"refs/heads/openregistry-build-automation","pushedAt":"2024-03-07T07:56:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"}},{"before":null,"after":"7b81dc655be1eb1b683826f7ebc9fd819f7f59a5","ref":"refs/heads/jay-dee7/V3.0","pushedAt":"2024-03-07T07:56:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"chore: Sync layout with upstream build\n\nSigned-off-by: jay-dee7 ","shortMessageHtmlLink":"chore: Sync layout with upstream build"}},{"before":"44eff417f93488aabc6151d8ac3e727d289cf5cc","after":"e8210ed12907d04a923dcd1da1f528fca4de61b8","ref":"refs/heads/jay-dee7/V2.0","pushedAt":"2024-03-06T08:51:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"add: Macro for spotlight","shortMessageHtmlLink":"add: Macro for spotlight"}},{"before":"71a5ba15e5a1e07779d4c9e2af66a13841dd4cb2","after":"dd3da03b9d8de287570d23245ff3a0c321bb0e31","ref":"refs/heads/V2.0","pushedAt":"2024-02-27T08:09:27.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Fix version.dtsi is reset after local firmware build (#385)\n\nIn #376 a new step was introduced for local builds to undo changes\r\nto the version.dtsi file after a build in order to reduce noise to the repo.\r\n\r\nUnfortunately the way used to execute the step causes the version.dtsi\r\nfile to be reset too early and therefore causes an incorrect version\r\nnumber to be used for the version macro when run locally. This went\r\nunfortunately undiscovered as the checked in version.dtsi was the same\r\non the day the change in #376 was tested and was not noticed until\r\nI build a new change to my keymap locally a few days ago.\r\n\r\nThe git command introduced in #376 is wrapped into a shell function.\r\n\r\nHowever what was missed is that commands run by the shell function are run when\r\nthe function calls are expanded by make. This causes the version.dtsi file to be reset\r\nbefore the firmware build process is even started which resultes in the version.dtsi\r\ncurrently checked in to the repo to be used for local builds instead of the\r\nnewly generated file when make starts.\r\n\r\nThis change updates how the git command to reset the version.dtsi\r\nis being called. It is no longer called within a shell function to ensure it\r\ndoes run in the order it is defined after the firmware build is complete.\r\n\r\nBuilds run through GitHub actions are not impacted and always used the correct version.dtsi\r\n\r\nFor more information and context see:\r\n - https://www.gnu.org/software/make/manual/html_node/Shell-Function.html\r\n - https://www.gnu.org/software/make/manual/html_node/Reading-Makefiles.html","shortMessageHtmlLink":"Fix version.dtsi is reset after local firmware build (KinesisCorporat…"}},{"before":"71a5ba15e5a1e07779d4c9e2af66a13841dd4cb2","after":"42a3ef791df86ea8a8bdc530a97a34c253efd188","ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-12-16T18:42:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"test-app-or[bot]","name":null,"path":"/apps/test-app-or","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/230443?s=80&v=4"},"commit":{"message":"build(ci): OpenRegistry build and push","shortMessageHtmlLink":"build(ci): OpenRegistry build and push"}},{"before":null,"after":"71a5ba15e5a1e07779d4c9e2af66a13841dd4cb2","ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-12-16T18:42:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"test-app-or[bot]","name":null,"path":"/apps/test-app-or","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/230443?s=80&v=4"},"commit":{"message":"Update ZMK (#248)\n\nTweaks to point to new ZMK branch, changes to support this.","shortMessageHtmlLink":"Update ZMK (KinesisCorporation#248)"}},{"before":"9b1eeb9d4489e57abaccef30da6613128b6f1426","after":"44eff417f93488aabc6151d8ac3e727d289cf5cc","ref":"refs/heads/jay-dee7/V2.0","pushedAt":"2023-10-30T10:32:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"add: Macro for spotlight","shortMessageHtmlLink":"add: Macro for spotlight"}},{"before":"5d42247f3f707d0ab00208b643e5972504c8ee5e","after":"71a5ba15e5a1e07779d4c9e2af66a13841dd4cb2","ref":"refs/heads/V2.0","pushedAt":"2023-10-30T10:31:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Update ZMK (#248)\n\nTweaks to point to new ZMK branch, changes to support this.","shortMessageHtmlLink":"Update ZMK (KinesisCorporation#248)"}},{"before":"7e20d8dec4af16b17ac14bdd4c7970d3dbfa2b58","after":"5d42247f3f707d0ab00208b643e5972504c8ee5e","ref":"refs/heads/V2.0","pushedAt":"2023-07-19T17:39:14.493Z","pushType":"push","commitsCount":1,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Add Update instructions, Assets folder (#178)","shortMessageHtmlLink":"Add Update instructions, Assets folder (KinesisCorporation#178)"}},{"before":"7e20d8dec4af16b17ac14bdd4c7970d3dbfa2b58","after":"5d42247f3f707d0ab00208b643e5972504c8ee5e","ref":"refs/heads/V2.0","pushedAt":"2023-07-19T17:39:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Add Update instructions, Assets folder (#178)","shortMessageHtmlLink":"Add Update instructions, Assets folder (KinesisCorporation#178)"}},{"before":"f42b59647039cbeec9436bff0d21d656d3d81467","after":null,"ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-06-23T05:36:03.338Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"}},{"before":"752d728ac719d7ce2f94ad464e9ddac8688cecc3","after":"9b1eeb9d4489e57abaccef30da6613128b6f1426","ref":"refs/heads/jay-dee7/V2.0","pushedAt":"2023-06-23T05:04:16.547Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"add: Macro for spotlight","shortMessageHtmlLink":"add: Macro for spotlight"}},{"before":null,"after":"752d728ac719d7ce2f94ad464e9ddac8688cecc3","ref":"refs/heads/jay-dee7/V2.0","pushedAt":"2023-06-23T04:54:48.801Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"add: Macro for spotlight","shortMessageHtmlLink":"add: Macro for spotlight"}},{"before":"11331ee9a5b6ee9b1c7bcab5173f82d9c9dfa2e8","after":"7e20d8dec4af16b17ac14bdd4c7970d3dbfa2b58","ref":"refs/heads/V2.0","pushedAt":"2023-06-23T03:47:57.418Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Merge pull request #163 from ReFil/Unmap\n\nrefactor(boards): cleanup pins and keys, disable battery reporting","shortMessageHtmlLink":"Merge pull request KinesisCorporation#163 from ReFil/Unmap"}},{"before":"11331ee9a5b6ee9b1c7bcab5173f82d9c9dfa2e8","after":"7e20d8dec4af16b17ac14bdd4c7970d3dbfa2b58","ref":"refs/heads/V2.0","pushedAt":"2023-06-23T03:47:57.377Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"Merge pull request #163 from ReFil/Unmap\n\nrefactor(boards): cleanup pins and keys, disable battery reporting","shortMessageHtmlLink":"Merge pull request KinesisCorporation#163 from ReFil/Unmap"}},{"before":"7fcd9bfe0fd52fb94fc16478e7d8ca169af42dba","after":"11331ee9a5b6ee9b1c7bcab5173f82d9c9dfa2e8","ref":"refs/heads/V2.0","pushedAt":"2023-05-12T06:22:41.730Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"},"commit":{"message":"add: Macro for spotlight","shortMessageHtmlLink":"add: Macro for spotlight"}},{"before":"7fcd9bfe0fd52fb94fc16478e7d8ca169af42dba","after":"f42b59647039cbeec9436bff0d21d656d3d81467","ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-05-08T11:45:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"test-app-or[bot]","name":null,"path":"/apps/test-app-or","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/230443?s=80&v=4"},"commit":{"message":"build(ci): OpenRegistry build and push","shortMessageHtmlLink":"build(ci): OpenRegistry build and push"}},{"before":null,"after":"7fcd9bfe0fd52fb94fc16478e7d8ca169af42dba","ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-05-08T11:45:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"test-app-or[bot]","name":null,"path":"/apps/test-app-or","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/230443?s=80&v=4"},"commit":{"message":"add: Macro for spotlight","shortMessageHtmlLink":"add: Macro for spotlight"}},{"before":"9dfc915f68e625c18b46eced21337492ef411a7d","after":null,"ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-05-08T11:45:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jay-dee7","name":"Jasdeep Singh","path":"/jay-dee7","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10788442?s=80&v=4"}},{"before":"7fcd9bfe0fd52fb94fc16478e7d8ca169af42dba","after":"9dfc915f68e625c18b46eced21337492ef411a7d","ref":"refs/heads/openregistry-build-automation","pushedAt":"2023-05-08T11:26:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"test-app-or[bot]","name":null,"path":"/apps/test-app-or","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/230443?s=80&v=4"},"commit":{"message":"build(ci): OpenRegistry build and push","shortMessageHtmlLink":"build(ci): OpenRegistry build and push"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEMOzlaQA","startCursor":null,"endCursor":null}},"title":"Activity · jay-dee7/Adv360-Pro-ZMK"}