Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicit use asString for performance #3821

Merged
merged 1 commit into from Dec 28, 2022
Merged

explicit use asString for performance #3821

merged 1 commit into from Dec 28, 2022

Conversation

dencat
Copy link
Contributor

@dencat dencat commented Dec 27, 2022

Replaced implicit toString call with explicit asString to improve performance (toString uses DefaultPrettyPrinter, which slows down, asString immediately produces the desired result)

@jlerbsc jlerbsc merged commit 96db29e into javaparser:master Dec 28, 2022
@jlerbsc
Copy link
Collaborator

jlerbsc commented Dec 28, 2022

Thank you for this contribution.

@jlerbsc jlerbsc added this to the Next release milestone Dec 28, 2022
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Fixed A PR that offers a fix or correction
Projects
None yet
Milestone
3.24.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dencat @jlerbsc