Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CFDictionaryGetCount to c.s.j.p.mac.CoreFoundation #1416

Merged
merged 3 commits into from Mar 11, 2022

Conversation

shalupov
Copy link
Contributor

No description provided.

@dbwiddis dbwiddis self-assigned this Mar 10, 2022
Copy link
Contributor

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the contribution.

One suggestion I'd make is to use the same type for the assertEquals that you expect, unless you feel strongly otherwise.

@dbwiddis dbwiddis merged commit 7ed3fa4 into java-native-access:master Mar 11, 2022
@shalupov shalupov deleted the dictionary-get-count branch March 11, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants