Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.99 catchExceptions deprecation warning is unavoidable #1497

Closed
bdwain opened this issue Feb 7, 2018 · 2 comments
Closed

v2.99 catchExceptions deprecation warning is unavoidable #1497

bdwain opened this issue Feb 7, 2018 · 2 comments

Comments

@bdwain
Copy link

bdwain commented Feb 7, 2018

Are you creating an issue in the correct repository?

yes

Expected Behavior

If I am not expliclty using catchExceptions, I should not see the deprecation warning

Current Behavior

I see the deprecation warning even though I am not using catchExceptions explicitly

Possible Solution

The catchExceptions function is called uncondtionally from here, and if the query parameter is not provided, defaults the value to true.

It seems like the value should default to false, and that the warning in the catchExceptions function should only be displayed if the value is truthy. If the catchExceptions function needs to be enabled by default and that a change to that would be breaking, that's fine, but it seems like odd that the deprecation warning would show up if you didn't opt in to the feature. Because you have to explicitly opt out of something you never opted in to to get rid of the warning.

Context

I am just running jasmine in a browser and would like to get rid of the deprecation warning.

Your Environment

  • Version used: 2.99
  • Environment name and version (e.g. Chrome 39, node.js 5.4): Chrome 64 node 8.9
  • Operating System and version (desktop or mobile): OS X High Sierra
@slackersoft
Copy link
Member

You're totally correct, catchExceptions should only be printing the deprecation warning if you turn it off, as that is the part that is deprecated. I'm going to release 2.99.1 shortly to fix this.

@bdwain
Copy link
Author

bdwain commented Feb 7, 2018

thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants