New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.99 catchExceptions deprecation warning is unavoidable #1497
Comments
You're totally correct, |
thanks for the quick response! |
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are you creating an issue in the correct repository?
yes
Expected Behavior
If I am not expliclty using catchExceptions, I should not see the deprecation warning
Current Behavior
I see the deprecation warning even though I am not using catchExceptions explicitly
Possible Solution
The catchExceptions function is called uncondtionally from here, and if the query parameter is not provided, defaults the value to true.
It seems like the value should default to false, and that the warning in the catchExceptions function should only be displayed if the value is truthy. If the catchExceptions function needs to be enabled by default and that a change to that would be breaking, that's fine, but it seems like odd that the deprecation warning would show up if you didn't opt in to the feature. Because you have to explicitly opt out of something you never opted in to to get rid of the warning.
Context
I am just running jasmine in a browser and would like to get rid of the deprecation warning.
Your Environment
The text was updated successfully, but these errors were encountered: