Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5378, stack overflow on large files #5380

Merged
merged 1 commit into from Oct 2, 2021
Merged

Fix #5378, stack overflow on large files #5380

merged 1 commit into from Oct 2, 2021

Conversation

GeoffreyBooth
Copy link
Collaborator

@edemaine
Copy link
Contributor

edemaine commented Oct 2, 2021

It looks like the browser compiler needs to be rebuilt. (Maybe I need to improve this error message...)

@GeoffreyBooth
Copy link
Collaborator Author

@edemaine Done. Otherwise does this look good?

@edemaine
Copy link
Contributor

edemaine commented Oct 2, 2021

Yes, it looks good to me (see other thread for details).

@GeoffreyBooth GeoffreyBooth merged commit d572d74 into jashkenas:master Oct 2, 2021
@GeoffreyBooth GeoffreyBooth deleted the fix-stack-overflow branch October 2, 2021 23:24
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeoffreyBooth @edemaine