Named exports for Node ESM for coffeescript
package
#5376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing ES module code in Node, the following doesn’t currently work:
This is because
coffeescript
is a CommonJS package that exports a single object (module.exports = CoffeeScript
) and Node’s “best guess” algorithm for trying to detect named exports of CommonJS packages can’t find CoffeeScript’s exports. Currently onlyimport CoffeeScript from 'coffeescript'
works.This PR simply adds several lines that explicitly define the named exports, which enables code like the first example to work. cc @guybedford
There are no tests for this, because the only way to currently run ESM code in Node from a CommonJS context is to either use an experimental API that’s moribund and likely to significantly change whenever it gets picked up again, or to spawn a child process of Node which is a bit too resource-intensive for our test suite. This code is extremely low risk, though, and doesn’t strike me as needing tests.