-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: generalize exempting of tests requiring advanced V8 features #4996
Comments
The first problem I'm seeing is that in the current architecture the scanning of test/ happens after re-invocation of bin/cake with (or without) --harmony. I will probably have to make some relatively invasive changes to implement this suggestion. |
I don’t think you need to worry about whether I also don’t like the idea of mixing a JSON file into the codebase. I know its function would be primarily to store data, hence it’s good to use a “data” file type, but editing that file would look very different from editing the rest of the codebase. Could we just use a regular |
I think you just cleared up all my confusion and I think I can keep the PR small. I should have something in an hour or so (fingers crossed). |
Fixed via #5003. |
Per discussion on #4893, tests which require switches be passed to node/coffee have their special handling hacked into Cakefile.
My proposal (and I'm already working on a PR) is to move special-case test files to their own directories under test/, accompanied by a config.json which contains the particulars of what's special about those tests.
(I figured it made more sense to open this than to continue off-topic discussion on the aforementioned PR.)
The text was updated successfully, but these errors were encountered: