Fix import json_available error #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Flask 1.1.0 or above remove json_available. ref: d362399e Signed-off-by: chang-ning <spiderpower02@gmail.com>
Signed-off-by: chang-ning <spiderpower02@gmail.com>
|
By the way, Is it necessary to support Python 3.3 and old version Flask? I found Flask's compatibility with Python 3.3 is bad. |
Signed-off-by: chang-ning <spiderpower02@gmail.com>
|
Flask 1.1.0 dropped support for Python 3.4, so I suppose supporting it in a Flask extension doesn't make much sense. |
|
This needs to be merged and released to support Flask 2.0. |
|
Hi, I solved all conflicts. thx |
jcomo
reviewed
Apr 13, 2020
| @@ -35,7 +35,7 @@ | |||
| from werkzeug.utils import cached_property | |||
|
|
|||
| # Use Flask's preferred JSON module so that our runtime behavior matches. | |||
There was a problem hiding this comment.
Can you move this comment down to line 51 (where the import happens)?
jcomo
approved these changes
Apr 13, 2020
|
@jcomo seems like the there hasn't been a new version since 0.8.0 in March? Would be great to have a new version that included this fix. Great repo BTW, thanks! |
|
@Garrett-R thanks for the ping. I just uploaded 0.8.1 to pypi. Cheers! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Flask 1.1.0 remove json_available for compatibility. Please refer to the Flask commit.
commit d362399e7ebfe167a27daef20e198ecabed1b49b Author: Gabriel Saldanha <gabrielcrsaldanha@gmail.com> Date: Wed Jun 27 08:23:44 2018 -0300 :fire: Remove code supposed to be removed at v1.0 diff --git a/flask/__init__.py b/flask/__init__.py index 1ab13c36..2e5670f5 100644 --- a/flask/__init__.py +++ b/flask/__init__.py @@ -43,7 +43,3 @@ from . import json # This was the only thing that Flask used to export at one point and it had # a more generic name. jsonify = json.jsonify - -# backwards compat, goes away in 1.0 -from .sessions import SecureCookieSession as Session -json_available = Truethanks,
chang-ning