From 901178db3174db1a386515a1e24c26f91fc16d61 Mon Sep 17 00:00:00 2001 From: Andrzej Jarmoniuk Date: Sat, 17 Dec 2022 11:18:18 +0100 Subject: [PATCH] Resolves #850: Protecting the display-plugin-updates mojo against a NPE in case the effective version of a plugin is not specified --- .../org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java b/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java index 15c6fccaed..9662357b8a 100644 --- a/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java +++ b/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java @@ -37,6 +37,7 @@ import java.util.List; import java.util.Map; import java.util.Objects; +import java.util.Optional; import java.util.Set; import java.util.Stack; import java.util.TreeMap; @@ -52,6 +53,8 @@ import org.apache.maven.model.BuildBase; import org.apache.maven.model.Model; import org.apache.maven.model.Plugin; +import org.apache.maven.model.PluginConfiguration; +import org.apache.maven.model.PluginManagement; import org.apache.maven.model.Prerequisites; import org.apache.maven.model.Profile; import org.apache.maven.model.ReportPlugin; @@ -620,7 +623,7 @@ private static String pad(String start, int len, String... ends) { buf.append(start); int padding = len; for (String end : ends) { - padding -= end.length(); + padding -= String.valueOf(end).length(); } buf.append(' '); while (buf.length() < padding) {