Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] Could not find a declaration file for module 'http-cache-semantics' #218

Closed
Maxim-Mazurok opened this issue Dec 26, 2022 · 3 comments · Fixed by #219
Closed
Labels

Comments

@Maxim-Mazurok
Copy link
Contributor

Describe the bug
Regression of #194
It was previously fixed in #195
And then broken again in #217
Perhaps we need to add a test to prevent this in the future?

How To Reproduce (best to provide workable code or tests!)
See #194

@jaredwray
Copy link
Owner

@Maxim-Mazurok are you getting this now? What is the code that I can validate off of as from my tests and validation it looks good.

@jaredwray
Copy link
Owner

Thanks for the pull request and merged + published as v10.2.5

@Maxim-Mazurok
Copy link
Contributor Author

@Maxim-Mazurok are you getting this now? What is the code that I can validate off of as from my tests and validation it looks good.

The reproduction is in #194 if you still need it:

  1. git clone -b create-pr-action/chore-npm-dedupe-0 https://github.com/Maxim-Mazurok/google-api-typings-generator
  2. cd google-api-typings-generator
  3. optional nvm i
  4. npm ci
  5. Observe the error

Thanks for the pull request and merged + published as v10.2.5

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants