New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak #222
Comments
@GalRab - looking into this as I believe this was changed do to the way we are handling the response. |
I created a new branch with a fix that would remove both. https://github.com/jaredwray/cacheable-request/tree/fixing-listener-memory-leak---issue-%23222 Can you validate that this resolves the issue? |
yes, it seems to have resolved the issue |
…issue-#222 fixing listener memory leak - issue #222
This has been released: https://github.com/jaredwray/cacheable-request/releases/tag/v10.2.6 |
We have a memory leak when there is a lot of concurrency requests, the memory is raised until the container crashed.
It cause by this line:
cachek.once('error', errorHandler);
// src/index.tsI noticed there was a commit (line 209) that changed the behavior when the listener is removed.
Why did it change to remove the listener on error rather than on response?
Does the listener never remove if there is no error?
The text was updated successfully, but these errors were encountered: