Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup 2 support #821

Closed
cncolder opened this issue Aug 23, 2020 · 2 comments · May be fixed by #889
Closed

Rollup 2 support #821

cncolder opened this issue Aug 23, 2020 · 2 comments · May be fixed by #889
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists topic: Rollup 2 Related to Rollup 2 upgrade
Milestone
v0.15.0 - Rollup ...

Comments

@cncolder
Copy link

Current Behavior

tsdx lock rollup@1.32.1 now

Desired Behavior

Upgrade to rollup 2

Suggested Solution

Release npm next tag tsdx@next

Who does this impact? Who is this for?

Some plugins (e.g. rollup-plugin-postcss) has drop support rollup 1

Describe alternatives you've considered

Additional context
@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 23, 2020 •
edited

Yea planning on doing this soon since #731 (comment) is causing a high vulnerability and requires Rollup v2.

Per #679 (comment), it wasn't easily possible before and rollup-plugin-postcss itself broke during the upgrade. Now enough time should have elapsed that it should be doable to upgrade it and all the related deps, but it's potentially quite breaking for tsdx.config.js users in potentially unexpected ways.
TS 3.8 private fields still have issues in a lot of places, but based on reports looks like we can update to TS 3.8+ safely so long as private fields aren't used.

@agilgur5 agilgur5 added the scope: dependencies Pull requests that update a dependency file label Aug 23, 2020
@agilgur5 agilgur5 linked a pull request Aug 29, 2020 that will close this issue
Update rollup to the latest version 🚀 #545
Closed
@agilgur5
Copy link
Collaborator

Duplicate of #545

@agilgur5 agilgur5 marked this as a duplicate of #545 Aug 29, 2020
@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Aug 29, 2020
@agilgur5 agilgur5 added the topic: Rollup 2 Related to Rollup 2 upgrade label Sep 17, 2020
@agilgur5 agilgur5 mentioned this issue Sep 28, 2020
Open
@agilgur5 agilgur5 linked a pull request Sep 28, 2020 that will close this issue
Update to Rollup 2 #889
Open
ludofischer added a commit to ludofischer/tsdx that referenced this issue Sep 29, 2020
@ludofischer
Update to Rollup 2.
f9b6340 
 - Update Rollup to 2.28.2. Fixes jaredpalmer#821, closes jaredpalmer#545
 - Update @rollup/plugin-commonjs. Upgrading this required Rollup 2 without any note in the changelog.  Closes jaredpalmer#727
 - Update @rollup/plugin-json to 4.1.0. v4.0.3 is the first to add Rollup 2 in the peerDep range. Older versions are forward-compatible but will produce a peerDep warning
 - Update @rollup/plugin-replace to 2.3.3. v2.3.2 is the first version to add Rollup 2 in the peerDep range.
 - Update rollup-plugin-terser to v7. v6 requires rollup 2 and Node 10+. v7 introduces Terser 5, requires Node >= 10 and supports some new JS syntax. fixes jaredpalmer#803, #fixes 797, closes jaredpalmer#731
 - Update rollup-plugin-postcss to 3.1. Closes jaredpalmer#693.
 - Remove sourcemap option from terser rollup plugin config, as of rollup-plugin-terser v6.0, it’s inferred automatically from Rollup’s output.source config.
aladdin-add pushed a commit to weiran-zsd/dts-cli that referenced this issue Aug 30, 2021
@ludofischer @aladdin-add
Update to Rollup 2.
cc38354 
 - Update Rollup to 2.28.2. Fixes jaredpalmer#821, closes jaredpalmer#545
 - Update @rollup/plugin-commonjs. Upgrading this required Rollup 2 without any note in the changelog.  Closes jaredpalmer#727
 - Update @rollup/plugin-json to 4.1.0. v4.0.3 is the first to add Rollup 2 in the peerDep range. Older versions are forward-compatible but will produce a peerDep warning
 - Update @rollup/plugin-replace to 2.3.3. v2.3.2 is the first version to add Rollup 2 in the peerDep range.
 - Update rollup-plugin-terser to v7. v6 requires rollup 2 and Node 10+. v7 introduces Terser 5, requires Node >= 10 and supports some new JS syntax. fixes jaredpalmer#803, #fixes 797, closes jaredpalmer#731
 - Update rollup-plugin-postcss to 3.1. Closes jaredpalmer#693.
 - Remove sourcemap option from terser rollup plugin config, as of rollup-plugin-terser v6.0, it’s inferred automatically from Rollup’s output.source config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists topic: Rollup 2 Related to Rollup 2 upgrade
Projects
None yet
Milestone
v0.15.0 - Rollup 2 + multi-entry + `p...
Development

Successfully merging a pull request may close this issue.

Update to Rollup 2 ludofischer/tsdx
Update rollup to the latest version 🚀 jaredpalmer/tsdx
2 participants
@cncolder @agilgur5