Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

size-limit GitHub Action fails on Node 10 #1089

Open
tsekityam opened this issue Oct 13, 2021 · 0 comments · May be fixed by #1090
Open

size-limit GitHub Action fails on Node 10 #1089

tsekityam opened this issue Oct 13, 2021 · 0 comments · May be fixed by #1090
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core)

Comments

@tsekityam
Copy link

tsekityam commented Oct 13, 2021 •
edited

Current Behavior

$ npx tsdx create mylib
$ cd mylib  
$ git init
$ git add --all
$ git commit -m "first commit"
[master (root-commit) 29e0eb0] first commit
 10 files changed, 7815 insertions(+)
 create mode 100644 .github/workflows/main.yml
 create mode 100644 .github/workflows/size.yml
 create mode 100644 .gitignore
 create mode 100644 LICENSE
 create mode 100644 README.md
 create mode 100644 package.json
 create mode 100644 src/index.ts
 create mode 100644 test/blah.test.ts
 create mode 100644 tsconfig.json
 create mode 100644 yarn.lock
$ git branch -M main
$ git remote add origin https://github.com/tsekityam/mylib.git
$ git push -u origin main

The project is pushed to GitHub, and CI is triggered. However, the CI task Build, lint, and test on Node 10.x and ubuntu-latest results in failure.

The error is

error @size-limit/file@6.0.3: The engine "node" is incompatible with this module. Expected version "^12.0.0 || ^14.0.0 || >=16.0.0". Got "10.24.1"
14
error Found incompatible module.

Expected behavior

All the CI task ran and completed successfully.

Suggested solution(s)

Remove node@10 from supported engine list.

Additional context

size-limit package removed node@10 support from 5.0. Node@10 is not supported anymore. We should remove it instead of downgrade size-limit package to 4.X

Your environment

npx: installed 1 in 1.55s

  System:
    OS: macOS 11.6
    CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
    Memory: 183.74 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.18.0 - /usr/local/opt/node@14/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 6.14.15 - /usr/local/opt/node@14/bin/npm
  Browsers:
    Edge: 94.0.992.47
    Firefox: 92.0
    Safari: 15.0
  npmPackages:
    tsdx: ^0.14.1 => 0.14.1 
    typescript: ^4.4.4 => 4.4.4
@tsekityam tsekityam linked a pull request Oct 13, 2021 that will close this issue
Open
@agilgur5 agilgur5 added the scope: templates Related to an init template, not necessarily to core (but could influence core) label Apr 11, 2022
@agilgur5 agilgur5 changed the title GitHub CI failure size-limit GitHub Action fails on Node 10 Apr 11, 2022
This was referenced Apr 11, 2022
Closed
Closed
maramal added a commit to maramal/regex that referenced this issue Nov 14, 2022
@maramal
According to issue 1089 I removed support for node 10 again.
dc5250e 
jaredpalmer/tsdx#1089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[basic] Remove Node.js 10 support tsekityam/tsdx
2 participants
@tsekityam @agilgur5