Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req.login(foundUser, next) never calls next #964

Open
MichaelJCole opened this issue Jan 18, 2023 · 0 comments
Open

req.login(foundUser, next) never calls next #964

MichaelJCole opened this issue Jan 18, 2023 · 0 comments

Comments

@MichaelJCole
Copy link

MichaelJCole commented Jan 18, 2023

Hi, I have an express route for email verification that should login the user

Expected behavior

req.login(foundUser, next)

should call next.

Actual behavior

next is never called

Steps to reproduce

I searched the Passport codebase and don't see req.login(user, cb) in the tests.

It looks like here is where Passport decorates req.login

The implementation appears to not call done in all code paths.

Environment

  • Operating System: Ubuntu 22.04
  • Node version: 18.12.1
  • passport version: 6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant