Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the monkey patching of node's
http.IncomingMessage
. Instead of that, it adds methods to each request as it passes through middleware, in a way that fits the patterns in other Express middleware.In addition to that, session internals have been refactored to operate on
req.session
directly, rather than a pointer maintained atreq._passport.session
. This is part of an ongoing effort to refactor away fromreq._passport
and clean up internals which use that.For those same reasons, use of
this._passport.instance._userProperty
has been refactored toreq._userProperty
. This cleans up internals while also allowing the possibility of setting a custom user property per-request via middleware, rather than globally for all requests processed through the singleton Passport instance.