Factor session access into session manager. #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 28, 2017
* Update core *passport* from version bump. Additional functionality added... claims backward compatible at jaredhanson/passport#598 (comment) * Redirect *passport-steam* to fork to include current release of 2.x and not maintenance branch of 1.x *NOTES(S)* * Brief discussion at OpenUserJS/passport-steam@d9198e3#commitcomment-23905032 * GH rechecked PASS * Goo rechecked PASS * Steam rechecked PASS
Martii
added a commit
to OpenUserJS/OpenUserJS.org
that referenced
this pull request
Aug 28, 2017
* Update core *passport* from version bump. Additional functionality added... claims backward compatible at jaredhanson/passport#598 (comment) * Redirect *passport-steam* to fork to include current release of 2.x and not maintenance branch of 1.x *NOTES(S)* * Brief discussion at OpenUserJS/passport-steam@d9198e3#commitcomment-23905032 * GH rechecked PASS * Goo rechecked PASS * Steam rechecked PASS Auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in refactoring session access into a session manager. Eventually, the session manager will be pluggable, so that implementation can choose to override session management.
The only API impacted by this PR is the SessionStrategy constructor, which now requires a
deserializeUserfunction. Because the SessionStrategy is instantiated internally by passport, it is unlikely that this will cause any compatibility issues. If an application were, for some reason, constructing the SessionStrategy outside of passport, then this argument will need to be passed.