Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent map writes to oldClients #128

Merged
merged 1 commit into from May 6, 2022
Merged

Fix concurrent map writes to oldClients #128

merged 1 commit into from May 6, 2022

Conversation

roboslone
Copy link

No description provided.

@roboslone
Copy link
Author

@jarcoal could you please take a look at this?

Copy link
Collaborator

@maxatome maxatome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roboslone,
thanks for your contribution.
Could you squash your commits, please?

race_test.go Outdated Show resolved Hide resolved
@roboslone
Copy link
Author

@maxatome
Squashed commits & fixed race_test.go.

@roboslone roboslone requested a review from maxatome May 6, 2022 08:47
transport.go Outdated Show resolved Hide resolved
@roboslone roboslone requested a review from maxatome May 6, 2022 09:18
@maxatome maxatome merged commit fbf2267 into jarcoal:v1 May 6, 2022
@maxatome
Copy link
Collaborator

maxatome commented May 6, 2022

Thanks!

@roboslone
Copy link
Author

@maxatome Do I need to do anything for a new version to become available in pkg.go.dev?

@maxatome
Copy link
Collaborator

maxatome commented May 6, 2022

I have to publish a new release. I'll try to do it before next Monday.

@maxatome
Copy link
Collaborator

maxatome commented May 6, 2022

https://github.com/jarcoal/httpmock/releases/tag/v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants