Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook to expand relative ticket refs to absolute #123

Open
bswck opened this issue Apr 20, 2024 · 1 comment
Open

Add a pre-commit hook to expand relative ticket refs to absolute #123

bswck opened this issue Apr 20, 2024 · 1 comment

Comments

@bswck
Copy link
Contributor

bswck commented Apr 20, 2024

The hook would possibly change commit messages to ensure absolute ticket refs.

E.g.

  • #27jaraco/skeleton#27, if we commit in skeleton,
  • #27jaraco/tempora#27, if we commit in tempora.

Addresses commit integrations mismatch.

@jaraco
Copy link
Owner

jaraco commented Apr 22, 2024

Yes, that sounds wise!

I'm a little worried about a pre-commit hook, because it requires the developer to have the hook installed (which in turn requires the developer to have the tool installed somewhere) and doesn't affect contributions through GitHub. What I'd like more is something like branch protection that would reject a push that mentions a bare issue number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants