Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib.metadata on all python versions >3.8 #628

Closed
jakkdl opened this issue Apr 18, 2023 · 1 comment
Closed

Use importlib.metadata on all python versions >3.8 #628

jakkdl opened this issue Apr 18, 2023 · 1 comment
Labels

Comments

@jakkdl
Copy link

jakkdl commented Apr 18, 2023

Since importlib.metadata is available since python>3.8, there's no reason to use importlib_metadata in those versions and require users to install an additional dependency. I think it should be as simple as modifying

if sys.version_info > (3, 12):

and
importlib_metadata >= 4.11.4; python_version < "3.12"

@jaraco
Copy link
Owner

jaraco commented May 24, 2023

Thanks for the request.

there's no reason to use importlib_metadata

Unfortunately, that's not correct. If you look at the last commit on py312compat.py, you'll be taken to #526, where you can see that importlib_metadata was bumped to solve a particular issue.

@jaraco jaraco closed this as completed May 24, 2023
@jaraco jaraco added the invalid label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants