You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this comment, Jonathan makes some good suggestions. Let's implement them.
Refactor the DBus initialization code to remove duplication.
Test a little bit more the supported() method. The existing implementation just checks one 'unsupported' case, and it's not even trivial by reading the test that it should be unsupported
Beware of BackendBasicTestCase, you _have_ to overload the supported() method otherwise most of the useful tests will be completely skipped!
No need to return None in get_password()
Document the calls to 'assert prompt == "/"' (comment/assert message) so that we know what it is used for and if it failed, why is it important that it failed.
In this comment, Jonathan makes some good suggestions. Let's implement them.
The text was updated successfully, but these errors were encountered: