Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretService cleanup #61

Closed
jaraco opened this issue Feb 24, 2015 · 1 comment
Closed

SecretService cleanup #61

jaraco opened this issue Feb 24, 2015 · 1 comment

Comments

@jaraco
Copy link
Owner

jaraco commented Feb 24, 2015

In this comment, Jonathan makes some good suggestions. Let's implement them.

  • Refactor the DBus initialization code to remove duplication.
    
  • Test a little bit more the supported() method. The existing implementation just checks one 'unsupported' case, and it's not even trivial by reading the test that it should be unsupported
    
  • Beware of BackendBasicTestCase, you _have_ to overload the supported() method otherwise most of the useful tests will be completely skipped!
    
  • No need to return None in get_password()
    
  • Document the calls to 'assert prompt == "/"' (comment/assert message) so that we know what it is used for and if it failed, why is it important that it failed. 
    

@jaraco jaraco closed this as completed Feb 24, 2015
@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

It appears the third item is no longer relevant. I've implemented the other four.


Original comment by: Jason R. Coombs

jaraco pushed a commit that referenced this issue Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant