libsecret: skip if there is no secret service running #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed priority gets called quite a lot (~8 times), so the priortiy/viable split that the code hints at seems like a good idea. In this case everything after the first call is quite fast with libsecret, so this shouldn't be a blocker. Just something I've noticed. |
jaraco
force-pushed
the
libsecret-check-session
branch
2 times, most recently
from
2589e8d
to
c8b5d86
Compare
lazka
force-pushed
the
libsecret-check-session
branch
from
c8b5d86
to
b000063
Compare
In case libsecret and its Python bindings are available the libsecret backend will get selected. This doesn't mean though that the system service it connects to is available. This leads to the backend being used and then failing, for example in get_credential() with: g-dbus-error-quark: The name org.freedesktop.secrets is unknown (2) To avoid this ask libsecret to connect to the system service first before considering to use it. Fixes jaraco#600
lazka
force-pushed
the
libsecret-check-session
branch
from
b000063
to
c3eb39b
Compare
|
(oops, small conflict as I was trying to force push the black CI error fix at the same time, should be fixed again) |
|
Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case libsecret and its Python bindings are available the libsecret backend will get selected. This doesn't mean though that the system service it connects to is available.
This leads to the backend being used and then failing, for example in get_credential() with:
g-dbus-error-quark: The name org.freedesktop.secrets is unknown (2)
To avoid this ask libsecret to connect to the system service first before considering to use it.
Fixes #600