New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scheme to be selectable in libsecret and SecretService backends #586
Conversation
jaraco
commented
Aug 5, 2022
- Add support for a scheme property in SecretService backend. Set to 'KeypassXC' to use the username/system convention from KeypassXC, either with KEYRING_PROPERTY_SCHEME or keyring.with_properties(scheme='KeypassXC'). Fixes Using python-keyring with KeePassXC #448.
- Add test for with_properties helper.
- Re-use with_properties in with_keychain.
- Deprecate macOS.Keyring.with_keychain, superseded by with_properties.
- Extract SchemeSelectable mixin
- Allow _query to include other keys
- Add SelectableScheme to libsecret.
- Add tests for SchemeSelectable.
…eypassXC' to use the username/system convention from KeypassXC, either with KEYRING_PROPERTY_SCHEME or keyring.with_properties(scheme='KeypassXC'). Fixes #448.
keyring/backend.py
Outdated
scheme = 'default' | ||
schemes = dict( | ||
default=dict(username='username', service='service'), | ||
KeypassXC=dict(username='UserName', service='Title'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be KeePassXC
(with e
instead of y
):
Please update it in all other places too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d35fc44.
Released as 23.8.0. |
I am sorry for not testing it earlier, but libsecret backend does not work :( Submitted #587. |