Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importlib_metadata optional on Python 3.10. #575

Closed
jaraco opened this issue May 23, 2022 · 3 comments · Fixed by #577
Closed

Make importlib_metadata optional on Python 3.10. #575

jaraco opened this issue May 23, 2022 · 3 comments · Fixed by #577

Comments

@jaraco
Copy link
Owner

jaraco commented May 23, 2022

That extra dependency will become optional again in Python 3.10 alpha 7.

Could it be marked as required only for Python < 3.10 in setup.cfg?

Originally posted by @dotlambda in #503 (comment)

@Mogost
Copy link

Mogost commented May 24, 2022

I noticed that in my project, only keyring depends on importlib_metadata.
What I don't understand is that all libraries put the dependency optional for python less than 3.8. Some examples are below

https://github.com/pytest-dev/pytest/blob/611b579d21f7e62b4c8ed54ab70fbfee7c6f5f64/setup.cfg#L51
https://github.com/PyCQA/flake8/blob/1c85f3d07c3aadf597db205dff597da2987745f7/setup.cfg#L45
https://github.com/sqlalchemy/sqlalchemy/blob/3d00de4cca7a80650316754f338317824f921940/setup.cfg#L38

@jaraco
Copy link
Owner Author

jaraco commented Jun 5, 2022

What I don't understand is that all libraries put the dependency optional for python less than 3.8.

As observed in the PR, there have been changes in importlib_metadata and only some of those are available in importlib.metadata for Python 3.9 and earlier. Since this project relies on importlib_metadata 3.6, it also needs importlib.metadata from Python 3.10 or later.

1 similar comment
@jaraco
Copy link
Owner Author

jaraco commented Jun 5, 2022

What I don't understand is that all libraries put the dependency optional for python less than 3.8.

As observed in the PR, there have been changes in importlib_metadata and only some of those are available in importlib.metadata for Python 3.9 and earlier. Since this project relies on importlib_metadata 3.6, it also needs importlib.metadata from Python 3.10 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants