Fix KWallet.get_credential() regression #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs: get_credential(service, username): Return a credential object stored in the active keyring. This object contains at least username and password attributes for the specified service, where the returned username may be different from the argument. Prior to this commit, get_credential() returned the password as a string, without wrapping the credential into a SimpleCredential object.
|
@MrAnno thanks for catching my mistake and fixing it 😊 |
|
@muggenhor My pleasure :) IMHO your version of the fix is more straightforward and explicit. |
|
Would be good to get some enhancements to the test suite to capture this guarantee. Just adding some type hints might be sufficient. |
jaraco
added a commit
that referenced
this pull request
Sep 12, 2020
… was hoping adding these hints would capture the missed expectation in #463, but alas, they do not.
|
As you can see in the above commit, I've added the type hints, but it seems mypy is comfortable with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#459 introduced a regression.
Docs:
Prior to this commit,
get_credential()returned the password as a string, without wrapping the credential into aSimpleCredentialobject.