Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #437

Closed
bhrutledge opened this issue May 3, 2020 · 2 comments
Closed

Add type annotations #437

bhrutledge opened this issue May 3, 2020 · 2 comments

Comments

@bhrutledge
Copy link
Contributor

I've been working on adding type annotations to Twine (pypa/twine#231), and keyring is one of our imports that's missing type hints/stubs. Is there any interest in adding those, either in the source or to https://github.com/python/typeshed?

See also: https://mypy.readthedocs.io/en/stable/existing_code.html

@jaraco
Copy link
Owner

jaraco commented May 7, 2020

I'm happy for someone to contribute type annotations. This codebase has mypy support, so anyone who would like to add annotations, especially ones that add meaningful value, I'm all for it.

@jaraco
Copy link
Owner

jaraco commented Dec 22, 2020

The project has one typing annotation and welcomes more. mypy tests pass and the project now includes a py.typed file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants